add config options for log colors#377
Merged
Merged
Conversation
| this._pipeline = this.pipeline || new Pipeline(this.hooks, { | ||
| ui: this.ui | ||
| ui: this.ui, | ||
| config: this.config |
Collaborator
Author
There was a problem hiding this comment.
shall we pass just a subset of config instead?
ghedamat
force-pushed
the
customize-default-color
branch
2 times, most recently
from
230c135 to
eb70406
Compare
ghedamat
force-pushed
the
customize-default-color
branch
from
eb70406 to
92f2816
Compare
Contributor
|
Collaborator
Author
|
@lukemelia correct, but that we need to do on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #358
coordinated with ember-cli-deploy/ember-cli-deploy-plugin#8